bug: Fix for index oob caused by terminal size mismatch #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basing off of fdehau/tui-rs#343, this may be why we had an oob error in #237?
ClementTsang
changed the title
ClementTsang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant, please provide screenshots of what results from the change:
Fix for an index out-of-bounds by resizing to a smaller terminal just after the program got the terminal size, but right before the terminal started drawing.
Based off of fdehau/tui-rs#343.
Issue
If applicable, what issue does this address?
Closes: #237
Type of change
Remove the irrelevant ones:
Test methodology
If required, please state how this was tested:
Furthermore, please tick which platforms this change was tested on:
Checklist
If relevant, see if the following have been met:
Other information
Provide any other relevant information: